SVC Tenders Route Boundary

Status: VERIFIED
Sprint: Cleanup Sprint 07

Purpose

This note records the current route boundary cleanup inside services/svc-tenders after Sprint 07. It does not claim clean domain extraction. It documents the safer internal split that now exists.

Active Route Registration Shape

Central route shell

File:

• services/svc-tenders/src/server.ts

Still owns:

• process/bootstrap setup
• config/db/pool setup
• auth middleware wiring
• tender/procurement routes
• auction declaration/internal auction routes
• ICPI / Butkhuzi / KES routes
• shared helper functions used by multiple route clusters

This remains a MIXED composition shell. It is smaller than before, but not yet fully decomposed.

Extracted vacancy route module

File:

• services/svc-tenders/src/routes/registerVacancyRoutes.ts

Owns active vacancy HTTP registration for:

• public vacancy list/detail
• applicant vacancy reads
• owner vacancy posting reads
• owner vacancy application reads
• vacancy posting mutations
• vacancy application mutations

Runtime dependencies injected from server.ts:

• VacancyReadRepository
• VacancyCommandHandlers
• auth/gating helpers
• payload/detail extraction helpers

Truth note:

• public vacancy reads remain MIXED because the read repository still unions projection-backed rows with legacy catalog fallback
• the route boundary is now clearer even though the data truth model is still mixed

Extracted accommodation route module

File:

• services/svc-tenders/src/routes/registerAccommodationRoutes.ts

Owns active accommodation HTTP registration for:

• accommodation listing mutations
• owner accommodation listing reads
• owner accommodation reservation reads
• accommodation booking mutations
• accommodation listing detail reads
• accommodation booking reads
• public accommodation list/detail/quote

Runtime dependencies injected from server.ts:

• AccommodationCommandHandlers
• AccommodationReadRepository
• AccommodationOwnerReadRepository
• auth helpers
• public mapping helpers
• payload/detail extraction helpers

Truth note:

• public accommodation reads are now clearly projection/read-model backed through AccommodationReadRepository
• booking-read endpoints no longer return fake empty arrays; they now use the real accommodation read repository methods that already existed

What Changed In Sprint 07

Before

server.ts directly registered:

• vacancy public reads
• vacancy owner/applicant reads
• vacancy mutations
• accommodation public reads
• accommodation owner reads
• accommodation booking reads
• accommodation mutations

This mixed:

• transport/request parsing
• domain route ownership
• read-model selection
• legacy compatibility behavior

After

server.ts now registers those clusters through:

• registerVacancyRoutes(...)
• registerAccommodationRoutes(...)

This makes the runtime boundary visible without changing public route paths.

Truthful Read Improvement

Sprint 07 made one behavior-level truth improvement:

• /my-accommodation-bookings
• /accommodation-listings/:id/bookings

These previously returned hardcoded empty arrays with migration comments. They now call the existing read-model methods on AccommodationReadRepository.

That does not create new booking semantics. It only exposes already-available read truth.

What Remains Centralized On Purpose

Still centralized in server.ts because wider movement would be riskier in this sprint:

• tender lifecycle routes
• tender declaration/evidence routes
• auction declaration/internal auction routes
• ICPI routes
• Butkhuzi routes
• KES orchestration routes
• shared auth/helper logic

What Remains Risky

Vacancy public discovery

Even with route extraction, vacancy public reads are still backed by mixed compatibility logic:

• projection tables/views
• legacy vacancies catalog fallback

That is explicit now, but not resolved.

Accommodation public discovery

Public accommodation discovery is cleaner than vacancy because it already uses AccommodationReadRepository, but ownership is still inside svc-tenders even though long-term platform direction points toward future accommodation/workstay extraction.

Recommended Next Route Cleanup

Recommended Sprint 08 direction:

• split server.ts further into tender/declaration routes vs KES/ICPI/Butkhuzi routes
• keep extraction internal first
• do not change route contracts yet